spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From andrewor14 <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-12386] [core] Fix NPE when spark.execut...
Date Thu, 17 Dec 2015 01:19:23 GMT
Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10339#discussion_r47858768
  
    --- Diff: core/src/main/scala/org/apache/spark/SparkEnv.scala ---
    @@ -256,7 +256,14 @@ object SparkEnv extends Logging {
           if (rpcEnv.isInstanceOf[AkkaRpcEnv]) {
             rpcEnv.asInstanceOf[AkkaRpcEnv].actorSystem
           } else {
    -        val actorSystemPort = if (port == 0) 0 else rpcEnv.address.port + 1
    --- End diff --
    
    @markhamstra we can make this a real oneliner if we use Option :)
    ```
    val actorSystemPort = if (port == 0) 0 else Option(rpcEnv.address).map(_.port + 1).getOrElse(port)
    ```
    not sure if that's easier or harder to read. Either way is fine.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message