spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hvanhovell <...@git.apache.org>
Subject [GitHub] spark pull request: [Spark-12374][SPARK-12150][SQL] Adding logical...
Date Wed, 16 Dec 2015 20:21:34 GMT
Github user hvanhovell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10335#discussion_r47828506
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicOperators.scala
---
    @@ -210,6 +210,37 @@ case class Sort(
       override def output: Seq[Attribute] = child.output
     }
     
    +case class Range(
    +    start: Long,
    +    end: Long,
    +    step: Long,
    +    numSlices: Int) extends LeafNode {
    +  require(step != 0, "step cannot be 0")
    +  val numElements: BigInt = {
    +    val safeStart = BigInt(start)
    +    val safeEnd = BigInt(end)
    +    if ((safeEnd - safeStart) % step == 0 || safeEnd > safeStart ^ step > 0) {
    --- End diff --
    
    ```xor```s are typically really hard to follow. I think this might be easier: ```safeEnd
> safeStart == step > 0```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message