spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From andrewor14 <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-7313] [Spark CORE] Configurable limit t...
Date Tue, 15 Dec 2015 20:13:29 GMT
Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5848#discussion_r47691687
  
    --- Diff: core/src/main/scala/org/apache/spark/Partitioner.scala ---
    @@ -118,7 +118,8 @@ class RangePartitioner[K : Ordering : ClassTag, V](
           Array.empty
         } else {
           // This is the sample size we need to have roughly balanced output partitions,
capped at 1M.
    -      val sampleSize = math.min(20.0 * partitions, 1e6)
    +      val maxSamples = rdd.sparkContext.getConf.getDouble("spark.partitioner.maxSamples",
1e6)
    --- End diff --
    
    if anything this should be `spark.rangePartitioner.maxSamples`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message