spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From felixcheung <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-11395][SPARKR] Support over and window ...
Date Mon, 07 Dec 2015 21:12:28 GMT
Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10094#discussion_r46878049
  
    --- Diff: R/pkg/R/window.R ---
    @@ -0,0 +1,88 @@
    +#
    +# Licensed to the Apache Software Foundation (ASF) under one or more
    +# contributor license agreements.  See the NOTICE file distributed with
    +# this work for additional information regarding copyright ownership.
    +# The ASF licenses this file to You under the Apache License, Version 2.0
    +# (the "License"); you may not use this file except in compliance with
    +# the License.  You may obtain a copy of the License at
    +#
    +#    http://www.apache.org/licenses/LICENSE-2.0
    +#
    +# Unless required by applicable law or agreed to in writing, software
    +# distributed under the License is distributed on an "AS IS" BASIS,
    +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +# See the License for the specific language governing permissions and
    +# limitations under the License.
    +#
    +
    +# window.R - Utility functions for defining window in DataFrames
    +
    +#' Window.partitionBy
    +#'
    +#' Creates a WindowSpec with the partitioning defined.
    +#'
    +#' @rdname Window.partitionBy
    +#' @export
    +#' @examples
    +#' \dontrun{
    +#'   Window.partitionBy("col1", "col2")
    +#'   Window.partitionBy(df$col1, df$col2)
    +#' }
    +setMethod("Window.partitionBy",
    --- End diff --
    
    right i was thinking it might be easier to users not having to remember which partitionBy()
to use if we could infer it by context and not having to name them differently


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message