spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From taishi-oss <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-10259] [ML] Add @since annotation to ml...
Date Fri, 04 Dec 2015 11:08:11 GMT
Github user taishi-oss commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8534#discussion_r46671245
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
    @@ -155,10 +155,13 @@ private[classification] trait LogisticRegressionParams extends ProbabilisticClas
      * in the future.
      */
     @Experimental
    -class LogisticRegression(override val uid: String)
    +@Since("1.4.0")
    +class LogisticRegression(
    +    @Since("1.4.0") override val uid: String)
       extends ProbabilisticClassifier[Vector, LogisticRegression, LogisticRegressionModel]
       with LogisticRegressionParams with DefaultParamsWritable with Logging {
     
    +  @Since("1.4.0")
    --- End diff --
    
    "git show" says it was introduced in v.1.4.0.
    ```
    hiro [spark] (master) > git show v1.2.0:mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
| grep "def this"   
    hiro [spark] (master) > git show v1.3.0:mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
| grep "def this"
    hiro [spark] (master) > git show v1.4.0:mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
| grep "def this"
      def this() = this(Identifiable.randomUID("logreg"))
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message