spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From davies <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-10277] [SQL] change the default plan fo...
Date Tue, 01 Dec 2015 23:43:29 GMT
Github user davies commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10075#discussion_r46357613
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLConf.scala ---
    @@ -449,17 +449,13 @@ private[spark] object SQLConf {
         doc = "When true, we could use `datasource`.`path` as table in SQL query"
       )
     
    -  val SPECIALIZE_SINGLE_DISTINCT_AGG_PLANNING =
    -    booleanConf("spark.sql.specializeSingleDistinctAggPlanning",
    -      defaultValue = Some(true),
    +  val AGG_PLANNING_15 =
    +    booleanConf("spark.sql.aggregationPlanning15",
    --- End diff --
    
    After the discussion with @nongli @yhuai , we agreed that the only reason we have this
flag here is to address the concern about performance regression for single distinct on low
cardinality aggregation since 1.5, also this is the way Oracle usually did. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message