spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From marmbrus <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-11954][SQL] Encoder for JavaBeans
Date Tue, 01 Dec 2015 01:33:07 GMT
Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9937#discussion_r46230424
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/ExpressionEncoder.scala
---
    @@ -67,6 +66,22 @@ object ExpressionEncoder {
           ClassTag[T](cls))
       }
     
    +  // TODO: improve error message for java bean encoder.
    +  def apply[T](beanClass: Class[T]): ExpressionEncoder[T] = {
    --- End diff --
    
    This is internal, but I probably wouldn't name this `apply` since we might want to support
other types of classes with different rules in the future.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message