Return-Path: X-Original-To: apmail-spark-reviews-archive@minotaur.apache.org Delivered-To: apmail-spark-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EAF491802E for ; Tue, 10 Nov 2015 03:05:20 +0000 (UTC) Received: (qmail 80783 invoked by uid 500); 10 Nov 2015 03:05:20 -0000 Delivered-To: apmail-spark-reviews-archive@spark.apache.org Received: (qmail 80755 invoked by uid 500); 10 Nov 2015 03:05:20 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 80744 invoked by uid 99); 10 Nov 2015 03:05:20 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 Nov 2015 03:05:20 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 33EA9E0A96; Tue, 10 Nov 2015 03:05:20 +0000 (UTC) From: tedyu To: reviews@spark.apache.org Reply-To: reviews@spark.apache.org References: In-Reply-To: Subject: [GitHub] spark pull request: Drop @VisibleForTesting annotation from QueryE... Content-Type: text/plain Message-Id: <20151110030520.33EA9E0A96@git1-us-west.apache.org> Date: Tue, 10 Nov 2015 03:05:20 +0000 (UTC) Github user tedyu commented on the pull request: https://github.com/apache/spark/pull/9585#issuecomment-155269336 I can follow classforname rule from scalastyle-config.xml - if we decide that @VisibleForTesting should not be used at all --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org