Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: vanzin <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-4632-spark@git.apache.org>
In-Reply-To: <git-pr-4632-spark@git.apache.org>
Subject: [GitHub] spark pull request: [SPARK-5847] Allow for namespacing
 metrics by ...
Content-Type: text/plain
Message-Id: <20151106031109.67CB2E393A@git1-us-west.apache.org>
Date: Fri,  6 Nov 2015 03:11:09 +0000 (UTC)

Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4632#discussion_r44099630
  
    --- Diff: core/src/main/scala/org/apache/spark/metrics/MetricsConfig.scala ---
    @@ -57,14 +59,16 @@ private[spark] class MetricsConfig(conf: SparkConf) extends Logging {
           case _ =>
         }
     
    -    propertyCategories = subProperties(properties, INSTANCE_REGEX)
    -    if (propertyCategories.contains(DEFAULT_PREFIX)) {
    -      val defaultProperty = propertyCategories(DEFAULT_PREFIX).asScala
    -      for((inst, prop) <- propertyCategories if (inst != DEFAULT_PREFIX);
    +    perInstanceProperties = subProperties(properties, INSTANCE_REGEX)
    +    if (perInstanceProperties.contains(DEFAULT_PREFIX)) {
    +      val defaultProperty = perInstanceProperties(DEFAULT_PREFIX).asScala
    +      for((inst, prop) <- perInstanceProperties if (inst != DEFAULT_PREFIX);
               (k, v) <- defaultProperty if (prop.get(k) == null)) {
             prop.put(k, v)
           }
         }
    +
    +    metricsNamespaceConfParam = properties.getProperty("namespace-conf-param", "spark.app.id")
    --- End diff --
    
    I'm not a fan of this config name. How about one of:
    
    - metrics.namespace
    - metrics.namePrefix
    - metrics.appName
    
    Or something like those?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org