spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vanzin <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-11655] [core] Fix deadlock in handling ...
Date Wed, 11 Nov 2015 18:26:59 GMT
GitHub user vanzin opened a pull request:

    https://github.com/apache/spark/pull/9633

    [SPARK-11655] [core] Fix deadlock in handling of launcher stop().

    The stop() callback was trying to close the launcher connection in the
    same thread that handles connection data, which ended up causing a
    deadlock. So avoid that by dispatching the stop() request in its own
    thread.
    
    On top of that, add some exception safety to a few parts of the code,
    and use "destroyForcibly" from Java 8 if it's available, to force
    kill the child process. The flip side is that "kill()" may not actually
    work if running Java 7.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vanzin/spark SPARK-11655

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/9633.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #9633
    
----
commit 9fcd201a24a1d5631ddfe971c6761cc511dd1a54
Author: Marcelo Vanzin <vanzin@cloudera.com>
Date:   2015-11-11T18:14:03Z

    [SPARK-11655] [core] Fix deadlock in handling of launcher stop().
    
    The stop() callback was trying to close the launcher connection in the
    same thread that handles connection data, which ended up causing a
    deadlock. So avoid that by dispatching the stop() request in its own
    thread.
    
    On top of that, add some exception safety to a few parts of the code,
    and use "destroyForcibly" from Java 8 if it's available, to force
    kill the child process. The flip side is that "kill()" may not actually
    work if running Java 7.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message