spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From HyukjinKwon <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-9557][SQL] Refactor ParquetFilterSuite ...
Date Mon, 09 Nov 2015 02:21:50 GMT
GitHub user HyukjinKwon opened a pull request:

    https://github.com/apache/spark/pull/9554

    [SPARK-9557][SQL] Refactor ParquetFilterSuite and remove old ParquetFilters code

    Actually this was resolved by https://github.com/apache/spark/pull/8275.
    
    But I found the JIRA issue for this is not marked as resolved since the PR above resolved
another issue but the PR above resolved both.
    
    I commented that this is resolved by the PR above; however, I opened this PR as I would
like to just add 
    a little bit of corrections. 
    
    In the previous PR, I refactored the test by not reducing just collecting filters; however,
this actually creates filters after reducing in the DataSourceStrategy, which the original
test codes (before being refactored) followed this.
    
    In this PR, I just followed the original way to collect filters by reducing.
    
    I would like to close this if this PR is inappropriate and somebody would like this deal
with it in the separate PR related with this.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/HyukjinKwon/spark SPARK-9557

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/9554.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #9554
    
----
commit b2b3631d2e49b232954c64fc196a49b8736fa87b
Author: hyukjinkwon <gurwls223@gmail.com>
Date:   2015-11-09T02:15:21Z

    [SPARK-9557][SQL] Refactor ParquetFilterSuite and remove old ParquetFilters code

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message