spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From viirya <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-12018][SQL] Refactor common subexpressi...
Date Fri, 27 Nov 2015 03:41:12 GMT
Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10009#discussion_r46015674
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
    @@ -417,18 +413,12 @@ class CodeGenContext {
           val code = expr.gen(this)
           val fn =
             s"""
    -           |private void $fnName(InternalRow ${INPUT_ROW}) {
    -           |  if (!$isLoaded) {
    -           |    ${code.code.trim}
    -           |    $isLoaded = true;
    -           |    $isNull = ${code.isNull};
    -           |    $value = ${code.value};
    -           |  }
    +           |private ${javaType(expr.dataType)} $fnName(InternalRow ${INPUT_ROW}) {
    +           |  ${code.code.trim}
    +           |  $isNull = ${code.isNull};
    +           |  return ${code.value};
    --- End diff --
    
    ok. make sense.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message