spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cloud-fan <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-12018][SQL] Refactor common subexpressi...
Date Fri, 27 Nov 2015 03:27:40 GMT
Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10009#discussion_r46015355
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
    @@ -104,16 +104,13 @@ class CodeGenContext {
       val equivalentExpressions: EquivalentExpressions = new EquivalentExpressions
     
       // State used for subexpression elimination.
    -  case class SubExprEliminationState(
    -      isLoaded: String,
    -      code: GeneratedExpressionCode,
    -      fnName: String)
    +  case class SubExprEliminationState(isNull: String, value: String)
     
       // Foreach expression that is participating in subexpression elimination, the state
to use.
       val subExprEliminationExprs = mutable.HashMap.empty[Expression, SubExprEliminationState]
     
    -  // The collection of isLoaded variables that need to be reset on each row.
    -  val subExprIsLoadedVariables = mutable.ArrayBuffer.empty[String]
    +  // The collection of variables that need to be initialized on each row.
    --- End diff --
    
    I think `reset` is a more proper word here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message