spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GraceH <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-9552] Return "false" while nothing to k...
Date Thu, 26 Nov 2015 02:22:37 GMT
Github user GraceH commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9796#discussion_r45939198
  
    --- Diff: core/src/test/scala/org/apache/spark/deploy/StandaloneDynamicAllocationSuite.scala
---
    @@ -386,17 +386,21 @@ class StandaloneDynamicAllocationSuite
         // the driver refuses to kill executors it does not know about
         syncExecutors(sc)
         val executors = getExecutorIds(sc)
    +    val executorIdsBefore = executors.head
         assert(executors.size === 2)
         // kill executor 1, and replace it
         assert(sc.killAndReplaceExecutor(executors.head))
         eventually(timeout(10.seconds), interval(10.millis)) {
           val apps = getApplications()
           assert(apps.head.executors.size === 2)
    +      val executorIdsAfter = getExecutorIds(sc).head
    +      // make sure the old executors head has been killedAndReplaced.
    +      assert(executorIdsBefore != executorIdsAfter)
         }
     
         var apps = getApplications()
    -    // kill executor 1
    -    assert(sc.killExecutor(executors.head))
    +    // kill executor 1, and actually nothing to kill
    +    assert(!sc.killExecutor(executors.head))
         apps = getApplications()
         assert(apps.head.executors.size === 2)
    --- End diff --
    
    That is why killing nothing, and executors.size == 2. Since the previous 27 was killed.

    The real kill ({28}) is tested in the following case.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message