spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cloud-fan <>
Subject [GitHub] spark pull request: [SPARK-11856][SQL] add type cast if the real t...
Date Wed, 25 Nov 2015 05:23:20 GMT
Github user cloud-fan commented on a diff in the pull request:
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/encoders/ExpressionEncoder.scala
    @@ -235,12 +236,13 @@ case class ExpressionEncoder[T](
         val plan = Project(Alias(unbound, "")() :: Nil, LocalRelation(schema))
         val analyzedPlan = SimpleAnalyzer.execute(plan)
    +    val optimizedPlan = SimplifyCasts(analyzedPlan)
    --- End diff --
    I'm also thinking about if we should introduce `sqlContext` here, and use its analyzer
and optimizer. For now our encoder resolution is case sensitive regardless of the `CASE_SENSITIVE`

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message