spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dilipbiswal <>
Subject [GitHub] spark pull request: [SPARK-11863][SQL][WIP] Unable to resolve orde...
Date Mon, 23 Nov 2015 02:41:09 GMT
Github user dilipbiswal commented on the pull request:
    @cloud-fan Thank you for the explanation as always. Trying to see if i understood your
suggestion properly. Were you suggesting to add another case under ResolveSortReferences to
deal with sort operator with   Aggregation ? Or you were thinking to call resolveAndFindMissing
from within ResolveAggregateFunctions passing the grandchild ? Since most of the stuff were
happening in that function , i thought its easier to just refactor the evaluatedorderings
logic. However you understand this stuff a lot better. So i would go by your suggestion. Please
let me know.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message