spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JoshRosen <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-11899][SQL] API audit for GroupedDatase...
Date Sat, 21 Nov 2015 20:26:11 GMT
Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9880#discussion_r45550214
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/GroupedDataset.scala ---
    @@ -36,11 +37,13 @@ import org.apache.spark.sql.execution.QueryExecution
      * making this change to the class hierarchy would break some function signatures. As
such, this
      * class should be considered a preview of the final API.  Changes will be made to the
interface
      * after Spark 1.6.
    + *
    + * @since 1.6.0
      */
     @Experimental
    -class GroupedDataset[K, T] private[sql](
    +class GroupedDataset[K, V] private[sql](
         kEncoder: Encoder[K],
    -    tEncoder: Encoder[T],
    +    tEncoder: Encoder[V],
    --- End diff --
    
    Should this variable be renamed to `vEncoder`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message