spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gatorsmile <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-11633] [SQL] HiveContext's Case Insensi...
Date Thu, 19 Nov 2015 00:52:41 GMT
Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9762#discussion_r45285365
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
    @@ -425,7 +425,8 @@ class Analyzer(
                  */
                 j
               case Some((oldRelation, newRelation)) =>
    -            val attributeRewrites = AttributeMap(oldRelation.output.zip(newRelation.output))
    +            val attributeRewrites =
    +              AttributeMap(oldRelation.output.zip(newRelation.output).filter(x =>
x._1 != x._2))
    --- End diff --
    
    It can avoid extra compare and replacement in the subsequent transformation. For example,
in the test case I added, this change can avoid making a copy for the underlying `LogicalRDD`.

    
    That is my original fix. If you think this change is not needed, I can easily remove it.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message