spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From marmbrus <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-11633] [SQL] HiveContext's Case Insensi...
Date Wed, 18 Nov 2015 23:52:19 GMT
Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9762#discussion_r45279985
  
    --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/SQLQuerySuite.scala
---
    @@ -1479,4 +1481,18 @@ class SQLQuerySuite extends QueryTest with SQLTestUtils with TestHiveSingleton
{
             |FROM (SELECT '{"f1": "value1", "f2": 12}' json, 'hello' as str) test
           """.stripMargin), Row("value1", "12", 3.14, "hello"))
       }
    +
    +  test ("SPARK-11633: HiveContext throws TreeNode Exception : Failed to Copy Node") {
    +    val rdd1 = sparkContext.parallelize(Seq( Individual(1, 3), Individual(2, 1)))
    +    val df = hiveContext.createDataFrame(rdd1)
    +    df.registerTempTable("foo")
    --- End diff --
    
    Nit, most tests are now using this more concise style.  You can then avoid adding another
class. 
    ```scala
    val df = Seq((1, 3), (2, 1)).toDF("f1", "f2")
    df.registerTempTable("foo")
    ```



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message