spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sun-rui <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-11715][SPARKR] Add R support corr for C...
Date Wed, 18 Nov 2015 07:28:43 GMT
Github user sun-rui commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9680#discussion_r45167221
  
    --- Diff: R/pkg/R/functions.R ---
    @@ -259,6 +259,20 @@ setMethod("column",
               function(x) {
                 col(x)
               })
    +#' corr
    +#'
    +#' Computes the Pearson Correlation Coefficient for two Columns.
    +#'
    +#' @rdname corr
    +#' @name corr
    +#' @family math_funcs
    +#' @export
    +#' @examples \dontrun{corr(df$c, df$d)}
    +setMethod("corr", signature(x = "Column", col1 = "Column", col2 = "missing", method =
"missing"),
    --- End diff --
    
    #9366 only supports inter-column cov and cor of a DataFrame, not between columns of two
DataFrames. I think actually it is better to add alias in this PR. corr() operating on two
columns is similar to R cor() on two vectors.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message