spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From yhuai <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-11792] [SQL] SizeEstimator cannot provi...
Date Wed, 18 Nov 2015 04:37:41 GMT
Github user yhuai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9788#discussion_r45159226
  
    --- Diff: core/src/main/scala/org/apache/spark/util/SizeEstimator.scala ---
    @@ -32,6 +32,16 @@ import org.apache.spark.annotation.DeveloperApi
     import org.apache.spark.util.collection.OpenHashSet
     
     /**
    + * A trait that allows a class to give [[SizeEstimator]] more accurate size estimation.
    + * When a class extends it, [[SizeEstimator]] will query the `estimatedSize` first.
    + * If `estimatedSize` does not return [[None]], [[SizeEstimator]] will use the returned
size
    + * as the size of the object. Otherwise, [[SizeEstimator]] will do the estimation work.
    + */
    +private[spark] trait SizeEstimation {
    +  def estimatedSize: Option[Long]
    --- End diff --
    
    At the driver side, `UnsafeHashedRelation` is using a java hashmap.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message