spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From marmbrus <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-10186][SQL] support postgre array type ...
Date Mon, 16 Nov 2015 23:54:39 GMT
Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9662#discussion_r45003859
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala ---
    @@ -64,13 +64,18 @@ abstract class JdbcDialect {
        * Get the custom datatype mapping for the given jdbc meta information.
        * @param sqlType The sql type (see java.sql.Types)
        * @param typeName The sql type name (e.g. "BIGINT UNSIGNED")
    -   * @param size The size of the type.
    +   * @param precision The precision of the type.
    +   * @param scale The scale of the type.
        * @param md Result metadata associated with this type.
        * @return The actual DataType (subclasses of [[org.apache.spark.sql.types.DataType]])
        *         or null if the default type mapping should be used.
        */
       def getCatalystType(
    -    sqlType: Int, typeName: String, size: Int, md: MetadataBuilder): Option[DataType]
= None
    +    sqlType: Int,
    +    typeName: String,
    +    precision: Int,
    +    scale: Int,
    +    md: MetadataBuilder): Option[DataType] = None
    --- End diff --
    
    This is a public API, if we add fields here we are going to break any existing implementations.
 Do we have to do this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message