spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From liancheng <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-11661] [SQL] Still pushdown filters ret...
Date Thu, 12 Nov 2015 02:45:31 GMT
Github user liancheng commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9634#discussion_r44616431
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilterSuite.scala
---
    @@ -336,4 +336,29 @@ class ParquetFilterSuite extends QueryTest with ParquetTest with
SharedSQLContex
           }
         }
       }
    +
    +  test("SPARK-11661 Still pushdown filters returned by unhandledFilters") {
    +    import testImplicits._
    +    withSQLConf(SQLConf.PARQUET_FILTER_PUSHDOWN_ENABLED.key -> "true") {
    +      withTempPath { dir =>
    +        val path = s"${dir.getCanonicalPath}/part=1"
    +        (1 to 3).map(i => (i, i.toString)).toDF("a", "b").write.parquet(path)
    +        val df = sqlContext.read.parquet(path).filter("a = 2")
    +
    +        // This is the source RDD without Spark-side filtering.
    +        val childRDD =
    +          df
    +            .queryExecution
    +            .executedPlan.asInstanceOf[org.apache.spark.sql.execution.Filter]
    +            .child.
    +            execute()
    --- End diff --
    
    Nit: `.child.` looks weird


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message