spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From squito <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-8029] Robust shuffle writer
Date Wed, 11 Nov 2015 03:09:12 GMT
Github user squito commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9610#discussion_r44497624
  
    --- Diff: core/src/main/java/org/apache/spark/shuffle/sort/BypassMergeSortShuffleWriter.java
---
    @@ -155,9 +156,20 @@ public void write(Iterator<Product2<K, V>> records) throws
IOException {
           writer.commitAndClose();
         }
     
    -    partitionLengths =
    -      writePartitionedFile(shuffleBlockResolver.getDataFile(shuffleId, mapId));
    -    shuffleBlockResolver.writeIndexFile(shuffleId, mapId, partitionLengths);
    +    File output = shuffleBlockResolver.getDataFile(shuffleId, mapId);
    +    final File tmp = new File(output.getAbsolutePath() + "." + UUID.randomUUID());
    --- End diff --
    
    good point about creating the tmp files in the same dir as the dest to make sure we can
do the rename ... I had taken that for granted.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message