spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JoshRosen <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-6990] [Build] Add Java linting script; ...
Date Tue, 10 Nov 2015 19:05:29 GMT
Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9600#discussion_r44449339
  
    --- Diff: core/src/main/java/org/apache/spark/util/collection/TimSort.java ---
    @@ -120,8 +120,9 @@ public void sort(Buffer a, int lo, int hi, Comparator<? super K>
c) {
         assert c != null;
    --- End diff --
    
    Can you exclude this TimSort file, since it's third-party code?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message