spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From yhuai <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-9830] [SQL] Remove AggregateExpression1...
Date Tue, 10 Nov 2015 05:19:43 GMT
Github user yhuai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9556#discussion_r44371174
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
---
    @@ -141,6 +141,10 @@ case class UnresolvedFunction(
       override def nullable: Boolean = throw new UnresolvedException(this, "nullable")
       override lazy val resolved = false
     
    +  override def prettyString: String = {
    +    s"${name}(${children.map(_.prettyString).mkString(",")})"
    --- End diff --
    
    @rxin @marmbrus It is better to change the `prettyString` of `UnresolvedFunction` to get
rid of that `'` (e.g. `'abs`). The impact of this change is that if any user rely on that
`'`, his/her code will break.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message