spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From marmbrus <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-9830] [SQL] Remove AggregateExpression1...
Date Mon, 09 Nov 2015 23:40:12 GMT
Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9556#discussion_r44350660
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/SqlParser.scala ---
    @@ -272,7 +273,7 @@ object SqlParser extends AbstractSparkSQLParser with DataTypeParser
{
       protected lazy val function: Parser[Expression] =
         ( ident <~ ("(" ~ "*" ~ ")") ^^ { case udfName =>
           if (lexical.normalizeKeyword(udfName) == "count") {
    -        Count(Literal(1))
    +        AggregateExpression(Count(Literal(1)), mode = Complete, isDistinct = false)
    --- End diff --
    
    Is there a reason we can't just create unresolved functions here? (other than maybe the
distinct case?)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message