spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From brkyvz <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-11141][STREAMING] Batch ReceivedBlockTr...
Date Mon, 09 Nov 2015 01:13:22 GMT
Github user brkyvz commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9143#discussion_r44234779
  
    --- Diff: streaming/src/main/scala/org/apache/spark/streaming/scheduler/ReceiverTracker.scala
---
    @@ -488,7 +493,28 @@ class ReceiverTracker(ssc: StreamingContext, skipReceiverLaunch:
Boolean = false
               registerReceiver(streamId, typ, host, executorId, receiverEndpoint, context.senderAddress)
             context.reply(successful)
           case AddBlock(receivedBlockInfo) =>
    -        context.reply(addBlock(receivedBlockInfo))
    +        if (WriteAheadLogUtils.isBatchingEnabled(ssc.conf, isDriver = true)) {
    +          val f = Future {
    +            synchronized {
    +              if (active) {
    +                addBlock(receivedBlockInfo)
    +              } else {
    +                throw new IllegalStateException("Receiver Tracker Endpoint shutdown.")
    +              }
    +            }
    +          }(walBatchingThreadPool)
    +          f.onComplete { result =>
    +            synchronized {
    --- End diff --
    
    Per the race condition between @zsxwing and Hari


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message