spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rxin <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-11537] [SQL] fix negative hours/minutes...
Date Thu, 05 Nov 2015 20:28:41 GMT
Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9502#discussion_r44064762
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
    @@ -393,28 +393,35 @@ object DateTimeUtils {
       }
     
       /**
    +   * Returns the microseconds since year zero (-17999).
    +   */
    +  def absoluteMicroSeconds(us: SQLTimestamp): SQLTimestamp = {
    +    us + toYearZero * MICROS_PER_DAY
    +  }
    +
    +  /**
        * Returns the hour value of a given timestamp value. The timestamp is expressed in
microseconds.
        */
    -  def getHours(timestamp: SQLTimestamp): Int = {
    -    val localTs = (timestamp / 1000) + defaultTimeZone.getOffset(timestamp / 1000)
    -    ((localTs / 1000 / 3600) % 24).toInt
    +  def getHours(us: SQLTimestamp): Int = {
    --- End diff --
    
    microsecs?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message