spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vanzin <...@git.apache.org>
Subject [GitHub] spark pull request: SPARK-11326: Split networking in standalone mo...
Date Thu, 05 Nov 2015 18:09:07 GMT
Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9287#discussion_r44046222
  
    --- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala ---
    @@ -364,6 +364,12 @@ class SparkConf(loadDefaults: Boolean) extends Cloneable with Logging
{
       /** Does the configuration contain a given parameter? */
       def contains(key: String): Boolean = settings.containsKey(key)
     
    +  /** Returns a copy of this configuration with all the properties at `spark.srcNamespace.xxx`
    +    * copied to `spark.xxx` */
    +  def fromNamespace(namespace: Namespace): SparkConf = {
    --- End diff --
    
    `Namespace` is `private[spark]` but this method is public. Scala should have printed a
warning about this. But that means this method should be `private[spark]`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message