spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From srowen <...@git.apache.org>
Subject [GitHub] spark pull request: SPARK-6541 - Sort executors by ID (numeric)
Date Thu, 05 Nov 2015 14:32:42 GMT
Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9165#discussion_r44017076
  
    --- Diff: core/src/main/resources/org/apache/spark/ui/static/sorttable.js ---
    @@ -81,18 +81,18 @@ sorttable = {
           if (!headrow[i].className.match(/\bsorttable_nosort\b/)) { // skip this col
             mtch = headrow[i].className.match(/\bsorttable_([a-z0-9]+)\b/);
             if (mtch) { override = mtch[1]; }
    -        if (mtch && typeof sorttable["sort_"+override] == 'function') {
    -          headrow[i].sorttable_sortfunction = sorttable["sort_"+override];
    -        } else {
    -          headrow[i].sorttable_sortfunction = sorttable.guessType(table,i);
    -        }
    -        // make it clickable to sort
    -        headrow[i].sorttable_columnindex = i;
    -        headrow[i].sorttable_tbody = table.tBodies[0];
    -        dean_addEvent(headrow[i],"click", function(e) {
    +	      if (mtch && typeof sorttable["sort_"+override] == 'function') {
    --- End diff --
    
    This adds tab-based indentation instead of spaces; later extra space indents are used
where I think the indentation was correct. You might review and/or back out whatever superfluous
changes in whitespace that you can.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message