spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zsxwing <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-11361][Streaming] Show scopes of RDD op...
Date Wed, 04 Nov 2015 21:52:19 GMT
Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9315#discussion_r43945224
  
    --- Diff: streaming/src/main/scala/org/apache/spark/streaming/dstream/DStream.scala ---
    @@ -374,26 +374,53 @@ abstract class DStream[T: ClassTag] (
        * Wrap a body of code such that the call site and operation scope
        * information are passed to the RDDs created in this body properly.
        */
    -  protected def createRDDWithLocalProperties[U](time: Time)(body: => U): U = {
    +  protected[streaming] def createRDDWithLocalProperties[U](time: Time)(body: => U):
U = {
    +    createRDDWithLocalProperties(time, makeRDDOpsVisibleInUI = false)(body)
    +  }
    +
    +  /**
    +   * Wrap a body of code such that the call site and operation scope
    +   * information are passed to the RDDs created in this body properly.
    +   */
    +  protected[streaming] def createRDDWithLocalProperties[U](
    --- End diff --
    
    Instead of adding this method, why not add a new method `makeRDDOpsVisibleInUI` (or a
better name)? It's confusing that having two `createRDDWithLocalProperties` methods when implementing
a `DStream`: which one should be override? Without looking at the codes in `DStream`, people
cannot answer this question.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message