spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From felixcheung <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-10500][SPARKR][WIP] sparkr.zip cannot b...
Date Wed, 04 Nov 2015 06:37:31 GMT
Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9390#discussion_r43847164
  
    --- Diff: core/src/main/scala/org/apache/spark/api/r/RUtils.scala ---
    @@ -51,15 +59,30 @@ private[spark] object RUtils {
         val isYarnClient = master != null && master.contains("yarn") && deployMode
== "client"
     
         // In YARN mode, the SparkR package is distributed as an archive symbolically
    -    // linked to the "sparkr" file in the current directory. Note that this does not
apply
    -    // to the driver in client mode because it is run outside of the cluster.
    +    // linked to the "sparkr" file in the current directory and additional R packages
    +    // are distributed as an archive symbolically linked to the "rpkg" file in the
    +    // current directory.
    +    //
    +    // Note that this does not apply to the driver in client mode because it is run
    +    // outside of the cluster.
         if (isYarnCluster || (isYarnClient && !isDriver)) {
    -      new File("sparkr").getAbsolutePath
    +      val sparkRPkgPath = new File("sparkr").getAbsolutePath
    +      val rPkgPath = new File("rpkg")
    +      if (rPkgPath.exists()) {
    +        Seq(sparkRPkgPath, rPkgPath.getAbsolutePath)
    +      } else {
    +        Seq(sparkRPkgPath)
    +      }
         } else {
           // Otherwise, assume the package is local
           // TODO: support this for Mesos
    --- End diff --
    
    I think we need to check and fail Mesos explicitly..


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message