spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From davies <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-11425] Improve Hybrid aggregation
Date Tue, 03 Nov 2015 18:28:48 GMT
Github user davies commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9383#discussion_r43786236
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/TungstenAggregationIterator.scala
---
    @@ -762,15 +679,7 @@ class TungstenAggregationIterator(
       /**
        * Start processing input rows.
        */
    -  testFallbackStartsAt match {
    -    case None =>
    -      processInputs()
    -    case Some(fallbackStartsAt) =>
    -      // This is the testing path. processInputsWithControlledFallback is same as processInputs
    -      // except that it switches to sort-based aggregation after `fallbackStartsAt` input
rows
    -      // have been processed.
    -      processInputsWithControlledFallback(fallbackStartsAt)
    -  }
    +  processInputs(testFallbackStartsAt.getOrElse(Int.MaxValue))
    --- End diff --
    
    The reason I'd like to have a really high limit is to avoid the branch, like `testFallbackStartsAt.isDefined()
&& i < testFallbackStartsAt.get()`. It's a common trick, I think.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message