Return-Path: X-Original-To: apmail-spark-reviews-archive@minotaur.apache.org Delivered-To: apmail-spark-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3CF4918118 for ; Fri, 23 Oct 2015 19:16:22 +0000 (UTC) Received: (qmail 59266 invoked by uid 500); 23 Oct 2015 19:16:00 -0000 Delivered-To: apmail-spark-reviews-archive@spark.apache.org Received: (qmail 59244 invoked by uid 500); 23 Oct 2015 19:16:00 -0000 Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@spark.apache.org Received: (qmail 59207 invoked by uid 99); 23 Oct 2015 19:15:59 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 23 Oct 2015 19:15:59 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id CBB5FE01F5; Fri, 23 Oct 2015 19:15:59 +0000 (UTC) From: andrewor14 To: reviews@spark.apache.org Reply-To: reviews@spark.apache.org References: In-Reply-To: Subject: [GitHub] spark pull request: [SPARK-10984] [WIP] Simplify *MemoryManager cl... Content-Type: text/plain Message-Id: <20151023191559.CBB5FE01F5@git1-us-west.apache.org> Date: Fri, 23 Oct 2015 19:15:59 +0000 (UTC) Github user andrewor14 commented on the pull request: https://github.com/apache/spark/pull/9127#issuecomment-150667335 The high level refactoring looks good. Once you make it pass tests and address the remaining comments (all of which are minor) I will merge this. Thanks for all your work on this @JoshRosen. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org For additional commands, e-mail: reviews-help@spark.apache.org