Mailing-List: contact reviews-help@spark.apache.org; run by ezmlm
Precedence: bulk
From: cloud-fan <git@git.apache.org>
To: reviews@spark.apache.org
Reply-To: reviews@spark.apache.org
References: <git-pr-8909-spark@git.apache.org>
In-Reply-To: <git-pr-8909-spark@git.apache.org>
Subject: [GitHub] spark pull request: [SPARK-10810] [SQL] Improve session
 management...
Content-Type: text/plain
Message-Id: <20151002213503.8CA08E0007@git1-us-west.apache.org>
Date: Fri,  2 Oct 2015 21:35:03 +0000 (UTC)

Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8909#discussion_r41070271
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLContext.scala ---
    @@ -300,21 +303,25 @@ class SQLContext(@transient val sparkContext: SparkContext)
        * @group cachemgmt
        * @since 1.3.0
        */
    -  def isCached(tableName: String): Boolean = cacheManager.isCached(tableName)
    +  def isCached(tableName: String): Boolean = {
    +    cacheManager.lookupCachedData(table(tableName)).nonEmpty
    +  }
     
       /**
        * Caches the specified table in-memory.
        * @group cachemgmt
        * @since 1.3.0
        */
    -  def cacheTable(tableName: String): Unit = cacheManager.cacheTable(tableName)
    +  def cacheTable(tableName: String): Unit = {
    +    cacheManager.cacheQuery(this, table(tableName), Some(tableName))
    +  }
     
       /**
        * Removes the specified table from the in-memory cache.
        * @group cachemgmt
        * @since 1.3.0
        */
    -  def uncacheTable(tableName: String): Unit = cacheManager.uncacheTable(tableName)
    +  def uncacheTable(tableName: String): Unit = cacheManager.uncacheQuery(table(tableName))
    --- End diff --
    
    We can also add `cacheQuery` here so that we don't need to pass in a `SQLContext` every time we call `CacheManager.cacheQuery `


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org