spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rahulpalamuttam <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-10906][MLlib] More efficient SparseMatr...
Date Fri, 02 Oct 2015 01:24:35 GMT
GitHub user rahulpalamuttam opened a pull request:

    https://github.com/apache/spark/pull/8960

    [SPARK-10906][MLlib] More efficient SparseMatrix.equals

    @jkbradley
    Calls toBreeze.activeIterator which, for CSCMatrix, returns an iterator
    with only non zero values. The iterators are then converted to sets and
    checked for equality. Since the input parameter can be of type DenseMatrix
    the second set is filtered for non-zero values. This is because activeIterator
    for DenseMatrix returns all values. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rahulpalamuttam/spark RahulP_SparseMatrixEquals

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/8960.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #8960
    
----
commit f3f7e650455600c0d266395ac549090b959ada95
Author: rahul <rahulpalamut@gmail.com>
Date:   2015-10-02T01:19:04Z

    updated SparseMatrix equal method

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message