spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vanzin <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-11235] [network] Add ability to stream ...
Date Fri, 30 Oct 2015 07:41:38 GMT
Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9206#discussion_r43478074
  
    --- Diff: network/common/src/test/java/org/apache/spark/network/util/TransportFrameDecoderSuite.java
---
    @@ -0,0 +1,173 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.network.util;
    +
    +import java.nio.ByteBuffer;
    +import java.util.ArrayList;
    +import java.util.List;
    +import java.util.Random;
    +
    +import io.netty.buffer.ByteBuf;
    +import io.netty.buffer.Unpooled;
    +import io.netty.channel.ChannelHandlerContext;
    +import org.junit.Test;
    +import static org.junit.Assert.*;
    +import static org.mockito.Mockito.*;
    +
    +public class TransportFrameDecoderSuite {
    +
    +  @Test
    +  public void testFrameDecoding() throws Exception {
    +    Random rnd = new Random();
    +    TransportFrameDecoder decoder = new TransportFrameDecoder();
    +    ChannelHandlerContext ctx = mock(ChannelHandlerContext.class);
    +
    +    List<ByteBuf> buffers = new ArrayList<>();
    +    for (int i = 0; i < 100; i++) {
    +      // Create two buffers; the first one will be large enough to contain the first
full
    +      // frame and maybe a few bytes of the second frame.
    +      byte[] data1 = new byte[1024 * (rnd.nextInt(31) + 1)];
    +      byte[] data2 = new byte[1024 * (rnd.nextInt(31) + 1)];
    +      int totalSize = 2 * 8 + data1.length + data2.length;
    +      int size1 = 8 + data1.length + 8 * (rnd.nextInt(data2.length / 2) / 8);
    +      int size2 = totalSize - size1;
    +
    +      assertTrue(size1 >= data1.length + 8);
    +      assertTrue(size2 > 8);
    +
    +      ByteBuf buf1 = Unpooled.buffer(size1);
    +      ByteBuf buf2 = Unpooled.buffer(size2);
    +
    +      buf1.writeLong(data1.length + 8);
    +      buf1.writeBytes(data1);
    +
    +      int remaining = size1 - data1.length - 8;
    +      assertTrue(remaining % 8 == 0);
    +      if (remaining >= 8) {
    +        buf1.writeLong(data2.length + 8);
    +        remaining -= 8;
    +      } else {
    +        buf2.writeLong(data2.length + 8);
    +      }
    +
    +      if (remaining > 0) {
    +        buf1.writeBytes(data2, 0, remaining);
    +      }
    +      buf2.writeBytes(data2, remaining, data2.length - remaining);
    +      buffers.add(buf1);
    +      buffers.add(buf2);
    +    }
    +
    +    try {
    +      for (ByteBuf buf : buffers) {
    +        decoder.channelRead(ctx, buf);
    +      }
    +
    +      verify(ctx, times(buffers.size())).fireChannelRead(any(ByteBuf.class));
    --- End diff --
    
    yeah, I'll change it. it just happens that the number of buffers and number of frames
matches, and it would be better if they didn't.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message