spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JoshRosen <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-10342] [SPARK-10309] [SPARK-10474] [SPA...
Date Thu, 29 Oct 2015 21:03:44 GMT
Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9241#discussion_r43444037
  
    --- Diff: core/src/main/java/org/apache/spark/memory/TaskMemoryManager.java ---
    @@ -261,17 +397,14 @@ public long getOffsetInPage(long pagePlusOffsetAddress) {
        * value can be used to detect memory leaks.
        */
       public long cleanUpAllAllocatedMemory() {
    -    long freedBytes = 0;
    -    for (MemoryBlock page : pageTable) {
    -      if (page != null) {
    -        freedBytes += page.size();
    -        freePage(page);
    +    synchronized (this) {
    +      Arrays.fill(pageTable, null);
    --- End diff --
    
    Good idea.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message