spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From yhuai <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-9298][SQL] Add pearson correlation aggr...
Date Thu, 29 Oct 2015 19:48:02 GMT
Github user yhuai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8587#discussion_r43435127
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregates.scala
---
    @@ -747,6 +747,19 @@ case class LastFunction(
       }
     }
     
    +/**
    + * Calculate Pearson Correlation Coefficient for the given columns.
    + * Only support AggregateExpression2.
    + *
    + */
    +case class Corr(left: Expression, right: Expression)
    +    extends BinaryExpression with AggregateExpression with ImplicitCastInputTypes {
    --- End diff --
    
    This is just a place holder, right? Can we change it to `with AggregateExpression1` then
we throw an exception (UnsupportedOperatorException) in the `newInstance` method?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message