spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From JoshRosen <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-10984] [WIP] Simplify *MemoryManager cl...
Date Fri, 23 Oct 2015 19:41:35 GMT
Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9127#discussion_r42906184
  
    --- Diff: core/src/main/java/org/apache/spark/shuffle/sort/ShuffleExternalSorter.java
---
    @@ -316,9 +313,13 @@ private long freeMemory() {
         long memoryFreed = 0;
         for (MemoryBlock block : allocatedPages) {
           taskMemoryManager.freePage(block);
    -      shuffleMemoryManager.release(block.size());
    --- End diff --
    
    This memory is now released as part of `taskMemoryManager.freePage()`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message