spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From falaki <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-9319][SPARKR] Add support for setting c...
Date Thu, 22 Oct 2015 18:20:29 GMT
Github user falaki commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9218#discussion_r42785428
  
    --- Diff: R/pkg/R/DataFrame.R ---
    @@ -276,6 +276,57 @@ setMethod("names<-",
                 }
               })
     
    +#' @rdname columns
    +#' @name colnames
    --- End diff --
    
    Although it is simply wrapping another method, having example and some description helps
with in-line documentation. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message