spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mengxr <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-10264][Documentation, ML] Added Since a...
Date Tue, 20 Oct 2015 23:32:21 GMT
Github user mengxr commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8532#discussion_r42568292
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/recommendation/ALS.scala ---
    @@ -355,7 +383,11 @@ object ALS extends Logging {
        * Rating class for better code readability.
        */
       @DeveloperApi
    -  case class Rating[@specialized(Int, Long) ID](user: ID, item: ID, rating: Float)
    +  @Since("1.3.0")
    --- End diff --
    
    We don't need `@Since` annotation for developer APIs.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message