spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From squito <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-10116] [core] XORShiftRandom.hashSeed i...
Date Tue, 20 Oct 2015 15:53:10 GMT
Github user squito commented on the pull request:

    https://github.com/apache/spark/pull/8314#issuecomment-149612582
  
    @srowen @mengxr sorry for letting this lay around for so long, somehow I completely forgot
to update it.  so I updated the tests with a few magic values, but didn't update the algorithms
themselves.  I tried a brute force search over 1000 seeds for `Word2Vec`, but none of them
made the test pass.  And it looks like `MultiLayerPerceptronClassifier` just [ignores its
seed](https://github.com/apache/spark/blob/master/mllib/src/main/scala/org/apache/spark/ml/ann/Layer.scala#L777).
    
    fixing those remaining issues is probably a bit beyond me, but this can't be merged till
we get those fixes.  How would you like me to proceed here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message