spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vundela <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-11105][yarn] Distribute log4j.propertie...
Date Tue, 20 Oct 2015 14:39:40 GMT
Github user vundela commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9118#discussion_r42503914
  
    --- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
    @@ -497,6 +497,19 @@ private[spark] class Client(
        */
       private def createConfArchive(): File = {
         val hadoopConfFiles = new HashMap[String, File]()
    +
    +    // Uploading $SPARK_CONF_DIR/log4j.properties file to the distributed cache to make
sure that
    +    // the executors will use the latest configurations instead of the default values.
This is
    +    // required when user changes log4j.properties directly to set the log configurations.
If
    +    // configuration file is provided through --files then executors will be taking configurations
    +    // from --files instead of $SPARK_CONF_DIR/log4j.properties.
    --- End diff --
    
    Yes, thats correct. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message