spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rxin <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-11079] Review Netty-based RPC implement...
Date Tue, 13 Oct 2015 07:15:05 GMT
Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9091#discussion_r41833341
  
    --- Diff: core/src/main/scala/org/apache/spark/rpc/RpcTimeout.scala ---
    @@ -0,0 +1,131 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.rpc
    +
    +import java.util.concurrent.TimeoutException
    +
    +import scala.concurrent.{Awaitable, Await}
    +import scala.concurrent.duration._
    +
    +import org.apache.spark.SparkConf
    +import org.apache.spark.util.Utils
    +
    +
    +/**
    + * An exception thrown if RpcTimeout modifies a [[TimeoutException]].
    + */
    +private[rpc] class RpcTimeoutException(message: String, cause: TimeoutException)
    +  extends TimeoutException(message) { initCause(cause) }
    +
    +
    +/**
    + * Associates a timeout with a description so that a when a TimeoutException occurs,
additional
    + * context about the timeout can be amended to the exception message.
    + *
    + * @param duration timeout duration in seconds
    + * @param timeoutProp the configuration property that controls this timeout
    + */
    +private[spark] class RpcTimeout(val duration: FiniteDuration, val timeoutProp: String)
    --- End diff --
    
    I moved this into its own file -- but eventually it probably makes more sense to just
have this in spark.util package for more general timeouts.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message