spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mfliu <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARKR] [SPARK-10981] SparkR Join improvement...
Date Fri, 09 Oct 2015 18:34:12 GMT
Github user mfliu commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9029#discussion_r41663399
  
    --- Diff: R/pkg/R/DataFrame.R ---
    @@ -1414,9 +1414,10 @@ setMethod("where",
     #' @param x A Spark DataFrame
     #' @param y A Spark DataFrame
     #' @param joinExpr (Optional) The expression used to perform the join. joinExpr must
be a
    -#' Column expression. If joinExpr is omitted, join() wil perform a Cartesian join
    +#' Column expression. If joinExpr is omitted, join() will perform a Cartesian join
     #' @param joinType The type of join to perform. The following join types are available:
    -#' 'inner', 'outer', 'left_outer', 'right_outer', 'semijoin'. The default joinType is
"inner".
    +#' 'inner', 'outer', 'full', 'fullouter', leftouter', 'left',
    --- End diff --
    
    Would it make sense to add "right_outer" and "left_outer" along with "rightouter" and
"leftouter"?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message