spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From yhuai <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-10810] [SPARK-10902] [SQL] Improve sess...
Date Wed, 07 Oct 2015 18:24:17 GMT
Github user yhuai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8909#discussion_r41426540
  
    --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveContext.scala ---
    @@ -69,13 +84,24 @@ private[hive] class HiveQLDialect extends ParserDialect {
      *
      * @since 1.0.0
      */
    -class HiveContext(sc: SparkContext) extends SQLContext(sc) with Logging {
    +class HiveContext private[hive](
    +    sc: SparkContext,
    +    cacheManager: CacheManager,
    +    @transient execHive: ClientWrapper,
    +    @transient metaHive: ClientInterface) extends SQLContext(sc, cacheManager) with Logging
{
    --- End diff --
    
    Maybe add comments to explain what `execHive` and `metaHive` do?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message