spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cloud-fan <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-8654][SQL] Fix Analysis exception when ...
Date Tue, 06 Oct 2015 18:22:10 GMT
Github user cloud-fan commented on the pull request:

    https://github.com/apache/spark/pull/8983#issuecomment-145953466
  
    ok misleaded by the imperative code style, sorry for that...
    So we will return null if the `key` is null, or we can't find a value in `list` matching
our `key`, and there is null value inside `list`.
    
    This PR make `In` operation return null when `key` is NullType, which is right. But I
think we can do it further by returning null for any type of `key` which is literal null(probably
another PR).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message