spark-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From davies <...@git.apache.org>
Subject [GitHub] spark pull request: [SPARK-1267][PYSPARK] Adds pip installer for p...
Date Mon, 05 Oct 2015 18:00:17 GMT
Github user davies commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8318#discussion_r41175819
  
    --- Diff: python/pyspark/pyspark_version.py ---
    @@ -0,0 +1,17 @@
    +#
    +# Licensed to the Apache Software Foundation (ASF) under one or more
    +# contributor license agreements.  See the NOTICE file distributed with
    +# this work for additional information regarding copyright ownership.
    +# The ASF licenses this file to You under the Apache License, Version 2.0
    +# (the "License"); you may not use this file except in compliance with
    +# the License.  You may obtain a copy of the License at
    +#
    +#    http://www.apache.org/licenses/LICENSE-2.0
    +#
    +# Unless required by applicable law or agreed to in writing, software
    +# distributed under the License is distributed on an "AS IS" BASIS,
    +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +# See the License for the specific language governing permissions and
    +# limitations under the License.
    +#
    +__version__ = '1.5.0'
    --- End diff --
    
    I think it's error-prone to have multiple copy of version in different places, if someone
forget to update his, PySpark will break (even within the repo).
    
    I'd vote for generate the version during generating PyPI package. If PySpark came along
with Spark, we don't need this check (at least it shouldn't fail or slow).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Mime
View raw message